[API] Sales order filters #8331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
SchrodingersGat
commented
Oct 22, 2024
SchrodingersGat
commented
- Fixes for SalesOrderLineItem API endpoints
- Improvements to PUI tables
- Updated unit testing
SchrodingersGat
added
order
✅ Deploy Preview for inventree-web-pui-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8331 +/- ##
==========================================
+ Coverage 84.23% 84.28% +0.04%
==========================================
Files 1166 1166
Lines 52884 52929 +45
Branches 1942 1942
==========================================
+ Hits 44546 44610 +64
+ Misses 7855 7841 -14
+ Partials 483 478 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
matmair
approved these changes
Oct 22, 2024
|
@matmair some of the translated labels for the filters are already introspected from the API - any filter which directly matches an available field in the API endpoint can use the translated string from that field |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.